chore: remove debian-slim comment linking libatomic1 with arm - #2635
Merged
Merged
Conversation
libatomic1 is required for Debian and Node.js >=25
nschonni
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the outdated comment linking the use of
libatomic1toarmfrom Dockerfile-slim.template.To avoid unnecessarily generating new images, the generated Dockerfiles are left unchanged. They will be updated with each corresponding new release line update.
Motivation and Context
According to https://github.com/nodejs/node/blob/main/BUILDING.md#official-binary-platforms-and-toolchains
debiananddebian-slimDocker images do not pre-install thelibatomic1package.buildpack-deps(for examplebuildpack-deps:trixie), which the defaultnodeis based on, does includelibatomic1package.docker-node/Dockerfile-slim.template
Line 13 in 766ca4f
libatomic1witharmis outdated.node:26-trixie-slimimages fail to build withoutlibatomic1Testing Details
Confirm that
26/trixie-slimfails to build withoutlibatomic1on x64.Types of changes
Checklist