Skip to content

chore: remove debian-slim comment linking libatomic1 with arm - #2635

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:remove-libatomic1-comment
Sep 28, 2026
Merged

MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:remove-libatomic1-comment

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Description

Remove the outdated comment linking the use of libatomic1 to arm from Dockerfile-slim.template.

To avoid unnecessarily generating new images, the generated Dockerfiles are left unchanged. They will be updated with each corresponding new release line update.

Motivation and Context

According to https://github.com/nodejs/node/blob/main/BUILDING.md#official-binary-platforms-and-toolchains

Starting with Node.js 25, official Linux binaries are linked with libatomic and these systems must have the libatomic runtime installed and available at execution time to run the binaries. The package name for the libatomic runtime is typically libatomic or libatomic1 depending on your Linux distribution.

debian and debian-slim Docker images do not pre-install the libatomic1 package.

buildpack-deps (for example buildpack-deps:trixie), which the default node is based on, does include libatomic1 package.

# libatomic1 for arm
comment linking libatomic1 with arm is outdated.

node:26-trixie-slim images fail to build without libatomic1

Testing Details

Confirm that 26/trixie-slim fails to build without libatomic1 on x64.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

libatomic1 is required for Debian and Node.js >=25
@MikeMcC399 MikeMcC399 self-assigned this Sep 27, 2026
@MikeMcC399
MikeMcC399 marked this pull request as ready for review September 27, 2026 17:12
@MikeMcC399
MikeMcC399 requested a review from nschonni September 27, 2026 17:14
@MikeMcC399 MikeMcC399 mentioned this pull request Sep 27, 2026
12 tasks
@MikeMcC399
MikeMcC399 merged commit f93fd00 into nodejs:main Sep 28, 2026
1 check passed
@MikeMcC399
MikeMcC399 deleted the remove-libatomic1-comment branch September 28, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants