Skip to content

make test fails behind a proxy - #61473

Open
batrla wants to merge 1 commit into
nodejs:mainfrom
batrla:main
Open

make test fails behind a proxy#61473
batrla wants to merge 1 commit into
nodejs:mainfrom
batrla:main

Conversation

@batrla

@batrla batrla commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

make test fails behind a proxy

Running tests behind proxy fails when http_proxy and https_proxy variables are defined in the user environment.
Please see below relevant snippets of the output of make -j2 test.

This is on Linux.

  • without the fix:
$ export http_proxy=http://somehost:someport
$ export https_proxy=http://somehost:someport
$ gmake -j2 2>&1 | tee test.nofix.log
...
[07:02|% 100|+ 4985|-  35]: Done

Failed tests:
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-fetch.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-https-proxy.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-invalid-url.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-ipv6.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-no-proxy-port-specific.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-proxy-failure-500.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-proxy-failure-hang-up.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-proxy-request-connection-refused.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-request-proxy-post.mjs
out/Release/node /home/auser/node/test/client-proxy/test-http-request-proxy-post-server-failure.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-auth-failure.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-empty-response.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-fetch.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-handshake-failure.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-https-proxy.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-incomplete-headers.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-invalid-url.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-ipv6.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-malformed-response.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-proxy-failure-404.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-proxy-failure-500.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-proxy-failure-502.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-proxy-failure-hang-up.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-server-failure-hang-up.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-request-proxy-post.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-tunnel-timeout.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-tunnel-timeout-agent.mjs
out/Release/node /home/auser/node/test/client-proxy/test-use-env-proxy-cli-http.mjs
out/Release/node /home/auser/node/test/client-proxy/test-use-env-proxy-cli-https.mjs
out/Release/node /home/auser/node/test/client-proxy/test-use-env-proxy-precedence.mjs
out/Release/node /home/auser/node/test/client-proxy/test-https-proxy-request-connection-refused.mjs
out/Release/node --expose-internals /home/auser/node/test/parallel/test-http2-allow-http1-upgrade-ws.js
out/Release/node --inspect=0 --experimental-network-inspection --expose-internals /home/auser/node/test/parallel/test-inspector-network-fetch.js
make[1]: *** [Makefile:322: jstest] Error 1
make: *** [Makefile:349: test] Error 2
  • with the suggested fix:
$ export http_proxy=http://somehost:someport
$ export https_proxy=http://somehost:someport
$ gmake -j2 2>&1 | tee test.fix.log
...
[06:55|% 100|+ 5022|-   0]: Done                                              

All tests passed.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 22, 2026
@codecov

codecov Bot commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (673cdef) to head (bfa5e66).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61473      +/-   ##
==========================================
- Coverage   90.32%   90.32%   -0.01%     
==========================================
  Files         760      760              
  Lines      248553   248553              
  Branches    46910    46908       -2     
==========================================
- Hits       224510   224509       -1     
+ Misses      15462    15459       -3     
- Partials     8581     8585       +4

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harjothkhara harjothkhara mentioned this pull request Jul 10, 2026
Closed
@harjothkhara

harjothkhara commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

I ran into the test-inspector-network-fetch failure independently and had opened #64383 (now closed as a duplicate of this) before finding this PR.

To add a data point: I reproduced the failure with a live local forward proxy and verified this PR's approach fixes it. With http_proxy/https_proxy pointing at a proxy, EnvHttpProxyAgent routes the test's requests through it and the URL reported to Network.requestWillBeSent becomes a malformed concatenation of proxy origin + absolute-form target:

+ 'http://127.0.0.1:61537http://127.0.0.1:61542/hello-world'
- 'http://127.0.0.1:61542/hello-world'

With noProxy: '*' added (as this PR does), the test passes both with and without ambient proxy env vars. Hope this helps this land — it would be nice to get a CI run on it.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75636/

@trivikr trivikr removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75741/

@batrla @joyeecheung
test: make proxy tests runnable when there is a system proxy
bfa5e66 
Some client-proxy tests set HTTP_PROXY variable in the environment.
It's OK in general, however, in some specific cases, the user might
have already defined his own http_proxy setting in the environment.
The lowercase user setting takes precedence and leads to a test
failure. The fix cleans up the environment to avoid
an interaction between user and test proxy settings.

PR-URL: nodejs#61473
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung

joyeecheung commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I rebased the commit and force pushed to your branch, however this PR is not landable due to the lack of Signed-off-by trailer. @batrla Can you amend the commit to sign it off? See https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines - you need to do something like

git remote -v # Find the remote name corresponding to your fork
git checkout main
git fetch <your remote> main
git reset --hard <your remote>/main
git commit --amend -s
git push --force <your remote> main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@batrla @harjothkhara @nodejs-github-bot @joyeecheung @trivikr