Skip to content

test: use heapdump test for SecureContext memory tracking#62689

Open
mertcanaltin wants to merge 1 commit intonodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking
Open

test: use heapdump test for SecureContext memory tracking#62689
mertcanaltin wants to merge 1 commit intonodejs:mainfrom
mertcanaltin:fix/remove-cctest-memory-tracking

Conversation

@mertcanaltin
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin commented Apr 11, 2026

Replace cctest with a heap snapshot test for SecureContext memory tracking.

Refs: #59051

@joyeecheung #59051 (comment)

@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from fc600de to 8b10dc3 Compare April 11, 2026 09:32
@mertcanaltin mertcanaltin marked this pull request as draft April 11, 2026 09:32
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 11, 2026
@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from 8b10dc3 to 2f7595c Compare April 11, 2026 09:35
@mertcanaltin mertcanaltin marked this pull request as ready for review April 11, 2026 09:36
@mertcanaltin mertcanaltin force-pushed the fix/remove-cctest-memory-tracking branch from 2f7595c to 9fcc36d Compare April 11, 2026 10:08
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (726b220) to head (9fcc36d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62689      +/-   ##
==========================================
- Coverage   89.81%   89.80%   -0.02%     
==========================================
  Files         699      699              
  Lines      216331   216331              
  Branches    41355    41361       +6     
==========================================
- Hits       194294   194269      -25     
+ Misses      14156    14144      -12     
- Partials     7881     7918      +37     

see 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

key: fixtures.readKey('agent1-key.pem'),
});

validateByRetainingPath('Node / SecureContext', [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates two snapshots, I think you can just merge the two into one call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants