deps: backport V8 upstream fix for loong64 opcode 209#63731
Open
Javonne-liu wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
c773cdd to
3db807e
Compare
Origin commit message:
[loong64][compiler] Extend Word64Select instruction functionality
Change-Id: Iba762777642d2d2d3aa904f9afc1e9005139992e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7801520
Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Commit-Queue: Liu Yu <liuyu@loongson.cn>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Liu Yu <liuyu@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#107619}
Refs: v8/v8@c4d06ba
3db807e to
d51bfac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:#63721
LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/1031/)
Always reproduces on LoongArch64 when executing the make out/doc/api/addons.html command.
Error Log:
This has been fixed in the latest commit for the v8 loong64 architecture.
(Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7801520).
review.googlesource.com/c/v8/v8/+/7801520)。
I verified this locally by patching deps/v8. With the patch applied, make out/doc/api/addons.html runs successfully and the crash is completely resolved.
Origin commit message:
Refs: v8/v8@c4d06ba