async_hooks: clear context frame for thrown microtasks#64147
Open
mcollina wants to merge 1 commit into
Open
Conversation
Member
Author
|
cc @nodejs/diagnostics |
Qard
reviewed
Jun 26, 2026
Member
There was a problem hiding this comment.
Don't we generally want the context to be available in uncaughtException? We did a bunch of work at one point to ensure it would be there so uncaughtException handlers could attribute the errors to spans they came from in tracers. It'd probably be more correct to cut off the context after those handlers run. 🤔
Member
Author
I thought as well. The key assertion here is this one: https://github.com/nodejs/node/pull/64147/changes#diff-6c14bb576b8a1eaf12aeb421aec5efd35b58d92c8a02d668a83a2f74f9c6474fR18. |
Member
Author
|
Note that if we think the current behavior is correct, then I'll add a test for it to match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clears the AsyncContextFrame before rethrowing exceptions from
queueMicrotask()callbacks.V8 restores continuation-preserved embedder data for microtasks. If a microtask callback throws, exception reporting can re-enter JavaScript while the microtask's context frame is still current. Clearing the frame before rethrowing keeps subsequent exception formatting and microtasks from observing the throwing callback's AsyncLocalStorage state.
Includes a regression test covering a non-Error object thrown from a microtask whose string conversion queues another microtask.