Skip to content

process: handle closed stdio in execve - #65133

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process7
Open

process: handle closed stdio in execve#65133
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process7

Conversation

@Archkon

@Archkon Archkon commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Treat EBADF while preparing standard file descriptors as an indication that the descriptor is already closed instead of failing execve.

Skip closed descriptors during flag restoration, check restoration errors

Treat EBADF while preparing standard file descriptors as an indication
that the descriptor is already closed instead of failing execve.

Skip closed descriptors during flag restoration, check restoration
errors

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 8, 2026
@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (985aa07) to head (f574e9e).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/node_process_methods.cc 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65133      +/-   ##
==========================================
- Coverage   90.31%   90.29%   -0.03%     
==========================================
  Files         759      759              
  Lines      248299   248301       +2     
  Branches    46854    46863       +9     
==========================================
- Hits       224251   224200      -51     
- Misses      15468    15512      +44     
- Partials     8580     8589       +9     
Files with missing lines Coverage Δ
src/node_process_methods.cc 88.24% <33.33%> (-0.29%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants