src: apply multiple permissions improvements - #65158
Open
jasnell wants to merge 11 commits into
Open
Conversation
Use env_property strings for permissions since those are fixed. Avoid creating new string instances each time. Also use ToV8Value for a couple since we're in here. Signed-off-by: James M Snell <jasnell@gmail.com>
Since DiagnosticChannel permission messages always have the same shape and should be as low cost as possible, use a cached DictionaryTemplate for creating them Signed-off-by: James M Snell <jasnell@gmail.com>
Getting the name of the channel is unnecessary. Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Use a fixed array rather than an unordered list Signed-off-by: James M Snell <jasnell@gmail.com>
Improve the way the RadixTree works and apply a fast api call. Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Most of the PermissionBase subclasses used the identical simple pattern. Rather than define a bunch of individual identical permissions, use a single utility definition. Special cases like FsPermission are still possible but the simple case is kept... well, simple. Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #65158 +/- ##
==========================================
- Coverage 90.32% 90.30% -0.02%
==========================================
Files 759 750 -9
Lines 248325 248314 -11
Branches 46861 46862 +1
==========================================
- Hits 224303 224245 -58
- Misses 15467 15478 +11
- Partials 8555 8591 +36
🚀 New features to boost your workflow:
|
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/multiple-permission-improvements
branch
from
August 9, 2026 05:12
a6b8717 to
7dd8d04
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
meixg
approved these changes
Aug 9, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Qard
approved these changes
Aug 9, 2026
jasnell
force-pushed
the
jasnell/multiple-permission-improvements
branch
from
August 9, 2026 16:54
8e7292b to
4c995fc
Compare
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/multiple-permission-improvements
branch
from
August 9, 2026 17:02
4c995fc to
d110091
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply a range of improvements to src/permissions/*
Signed-off-by: James M Snell jasnell@gmail.com