Skip to content

src: escape Windows environment variables in task runner - #65217

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:escape-windows-env-var
Open

src: escape Windows environment variables in task runner#65217
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:escape-windows-env-var

Conversation

@aduh95

@aduh95 aduh95 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 11, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95
aduh95 requested a review from anonrig August 11, 2026 17:01
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 11, 2026
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 11, 2026
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (404b0cf) to head (9e7a313).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65217   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         760      760           
  Lines      248525   248553   +28     
  Branches    46894    46911   +17     
=======================================
+ Hits       224488   224516   +28     
+ Misses      15469    15466    -3     
- Partials     8568     8571    +3     
Files with missing lines Coverage Δ
src/node_task_runner.cc 89.32% <ø> (ø)

... and 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants