sqlite: restore connection state on reopen

[araujogui]

close() destroys the SQLite connection but keeps the DatabaseSync object, and Open() did not replay the state held on that object.

db.setAuthorizer(() => constants.SQLITE_DENY);
db.exec('CREATE TABLE x(a)');  // throws, as expected
db.close(); db.open();
db.exec('CREATE TABLE x(a)');  // succeeds — policy silently gone

Three cases:

• The authorizer lives in an internal field that outlives the connection. It was never re-registered, so the object reported an authorizer SQLite was no longer consulting.
• Limits written through db.limits.* went only to the connection, so they reverted to the constructor values.
• Extension loading was re-enabled from allow_load_extension_ (the constructor ceiling) instead of enable_load_extension_ (the current setting), so the connection flag contradicted a previous enableLoadExtension(false). Not exploitable — loadExtension() stays blocked by its own check, and the SQL load_extension() function is never enabled, since SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION enables only the C API. Fixed for consistency.

Fix: re-register the authorizer at the end of Open(), record runtime limit writes alongside the constructor options so both are replayed, and apply the current load-extension setting rather than the ceiling.

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codecov]

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (1f26576) to head (28b9ebf).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	92.85%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66042      +/-   ##
==========================================
- Coverage   90.35%   90.35%   -0.01%     
==========================================
  Files         792      792              
  Lines      275500   275509       +9     
  Branches    52791    52801      +10     
==========================================
+ Hits       248932   248934       +2     
  Misses      16992    16992              
- Partials     9576     9583       +7     

Files with missing lines	Coverage Δ
src/node_sqlite.h	87.27% <100.00%> (ø)
src/node_sqlite.cc	81.98% <92.85%> (+0.01%)	⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[trivikr]

Commit body says

Extension loading was re-enabled from the constructor ceiling rather than the current setting, leaving the SQL load_extension() function reachable after enableLoadExtension(false).

How's the SQL load_extension() function reachable?

[araujogui]

Commit body says

Extension loading was re-enabled from the constructor ceiling rather than the current setting, leaving the SQL load_extension() function reachable after enableLoadExtension(false).

How's the SQL load_extension() function reachable?

It was not, my mistake. Fixed!