vfs: unflag - #66318
Open
mcollina wants to merge 2 commits into
Open
vfs: unflag#66318mcollina wants to merge 2 commits into
mcollina wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Renegade334
reviewed
Sep 26, 2026
mcollina
force-pushed
the
unflag-node-vfs
branch
from
September 26, 2026 15:24
fae9252 to
26a1dc8
Compare
mcollina
marked this pull request as ready for review
September 29, 2026 14:21
jasnell
approved these changes
Sep 29, 2026
mcollina
added
the
request-ci
ShogunPanda
approved these changes
Sep 29, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Keep VFS enabled by default while allowing the negated flag to disable node:vfs exposure and --vfs-load. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
unflag-node-vfs
branch
from
September 29, 2026 14:58
1a91ed3 to
99c479f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66318 +/- ##
==========================================
- Coverage 92.78% 90.37% -2.41%
==========================================
Files 422 792 +370
Lines 192238 275502 +83264
Branches 29636 52803 +23167
==========================================
+ Hits 178367 248996 +70629
- Misses 13548 16924 +3376
- Partials 323 9582 +9259
🚀 New features to boost your workflow:
|
Member
|
Before unflagging, since we now own npmjs.com/vfs, can we allow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.