Conversation
Cover native writes, immutable source copies, and view serialization across the affected API families. Exercise the Node-API detach abort using the existing typed-array addon and mark it as an expected failure. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66350 +/- ##
==========================================
+ Coverage 90.36% 90.37% +0.01%
==========================================
Files 792 792
Lines 275386 275578 +192
Branches 52770 52849 +79
==========================================
+ Hits 248859 249067 +208
+ Misses 16936 16923 -13
+ Partials 9591 9588 -3 🚀 New features to boost your workflow:
|
Collaborator
avivkeller
approved these changes
Sep 28, 2026
Member
|
LGTM, but we should try and fix these rather than marking them as known issues. I'll work on fs. |
panva
added
author ready
nodejs-github-bot
added
the
lacks-second-approval
aduh95
reviewed
Sep 30, 2026
aduh95
removed
the
author ready
aduh95
reviewed
Sep 30, 2026
panva
removed
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover native writes, immutable source copies, and view serialization across the affected API families. Exercise the Node-API detach abort using the existing typed-array addon and mark it as an expected failure.
Refs: #66346