meta: exclude .github/ from Prettier formatting - #1026
Closed
ovflowd wants to merge 1 commit into
Closed
Conversation
Prettier reformats workflow YAML files on every format run (e.g. normalising double-quoted cron strings to single-quoted). The update-links workflow then runs `node --run format` before committing changes, so git-auto-commit-action would try to push a workflow-file diff — which GitHub rejects unless the token has `workflows` write permission. Excluding `.github/` from Prettier stops the nightly run from producing spurious workflow file modifications. Refs #1020 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LXvbysVPDnes541gBuD1ia
MattIPv4
requested changes
Sep 9, 2026
MattIPv4
left a comment
MattIPv4
left a comment
Member
There was a problem hiding this comment.
I don't understand why we would exclude these, rather than formatting them correctly and enforcing that in CI?
Member
Author
I'd argue that these shouldn't be formatted within a GitHub workflow.. But sure, we can simply fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier reformats workflow YAML on every
formatrun — e.g. normalisingcron: "0 0 * * *"to single quotes. The update-links workflow runsnode --run formatbefore committing, sogit-auto-commit-actionpicks up the diff and tries to push a workflow file change. GitHub rejects that unless the token hasworkflowswrite permission.Adding
.github/to.prettierignorestops the nightly run from producing spurious workflow file diffs.Refs #1020