feat(tickets): point ticket links at Sympla - #64
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates website ticket links from Guild to Sympla and simplifies the ticket card to a localized purchase CTA.
Changes:
- Centralizes the Sympla ticket URL.
- Replaces live ticket tiers with localized CTA text.
- Fixes ticket-card alignment and removes obsolete tier styles.
| File | Description |
|---|---|
src/website/scss/pages/_ticket-selection.scss |
Centers card content and removes tier styles. |
src/website/configs/definitions.ts |
Updates the shared ticket URL. |
src/website/components/home/TicketSelection.tsx |
Replaces live tiers with a Sympla CTA. |
i18n/pt-BR/code.json |
Adds Portuguese CTA text. |
i18n/es-419/code.json |
Adds Spanish CTA text. |
i18n/en-US/code.json |
Adds English CTA text. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # src/website/configs/definitions.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets are on Sympla now, so every ticket link on the site (navbar buttons, the tickets card on the home page and the event schema for search engines) points to https://www.sympla.com.br/evento/jsconf-brasil/3593934 instead of the guild event.
The tickets card used to list the tiers it pulled live from guild, which would show three guild tiers while sending people to Sympla, and Sympla's public API has no way to list ticket types or prices. So the card is now just a "Comprar na Sympla" button. I also fixed its flex alignment, it was never centering the content, you just couldn't see it with the tier list filling the width.
CI will fail on the vote tests, that's the voting deadline in the past and it's already fixed in #63.