Repository navigation
Bugfix: Skip component cleanup when servicing is pending - #654
Open
CaioFPeres wants to merge 1 commit into
Open
CaioFPeres wants to merge 1 commit into
CaioFPeres wants to merge 1 commit into
Conversation
Check package, feature, and pending-marker state before invoking DISM cleanup. Serviceable builds now skip cleanup with a warning, while Core and component payload removal stop safely when pending work is detected. Add regression tests and document the behavior. Without this fix, every build of a serviceable image would fail to clean up the component store, leaving it in an error state and preventing iso build completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip component cleanup when servicing is pending
Check package, feature, and pending-marker state before invoking DISM cleanup. Serviceable builds now skip cleanup with a warning, while Core and component payload removal stop safely when pending work is detected.
Add regression tests and document the behavior.
Without this fix, every build of a serviceable image would fail to clean up the component store, leaving it in an error state and preventing iso build completion.
Problem found on official 26H2 ISO.
Logs (see "Retained because this image has pending servicing operations"):