fix(head): resolve reactive input before pushing to unhead - #1005
Open
Carpediem94 wants to merge 2 commits into
Open
fix(head): resolve reactive input before pushing to unhead#1005Carpediem94 wants to merge 2 commits into
Carpediem94 wants to merge 2 commits into
Conversation
Fixes nuxt-modules#1004 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for friendly-lamington-fb5690 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
- Coverage 28.96% 28.10% -0.86%
==========================================
Files 12 12
Lines 328 338 +10
Branches 98 100 +2
==========================================
Hits 95 95
- Misses 233 243 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004
🔗 Linked issue
Issue #1004
❓ Type of change
📚 Description
@unhead/vue'sclientUseHeadresolves reactive input withwalkResolver(input, VueResolver)inside awatchEffectbefore pushing an entry. The composable this module registers in its place pushed the raw input, and the client head has no prop resolver of its own —@unhead/vue/serveris the only one created withpropResolvers: [VueResolver], which is why this never showed up during SSR.I used Claude Opus 5 to analyze the problem and find a possible solution, before submit PR I review the code and make some changes on my own (I prefer to let "claude contribute" in the commit for transparency).
Currently I have already a workaround on my business projects to fix this error, so I decide to contribute to the repository.