test: stop two fixtures racing the work they are checking - #1548
Conversation
commit: |
CLI benchmark
Full report
|
| Setting | Value |
|---|---|
| Baseline | ref:9cb3b3025b94b64acee0fd878c88a199deefc616 (v4.0.0-alpha.1) |
| Head | local packages/nuxt-cli at 46e3862 (v4.0.0-alpha.1) |
| Node | v24.21.0 |
| OS | Linux 6.17.0 (kernel 6.17.0-1022-azure) |
| CPU | AMD EPYC 7763 64-Core Processor x 4 |
| Memory | 15.6 GB |
| Load average at start | 0.84, 0.26, 0.09 |
| Run started | 2026-09-21T23:20:11.118Z |
Cold CLI startup
Median of 15 interleaved runs per command, one warmup discarded.
| Command | baseline v4.0.0-alpha.1 median | head v4.0.0-alpha.1 median | Delta | baseline v4.0.0-alpha.1 min / p95 | head v4.0.0-alpha.1 min / p95 |
|---|---|---|---|---|---|
nuxt --version |
66 ms | 65 ms | -1.1% | 63 ms / 68 ms | 62 ms / 70 ms |
nuxt --version (first output byte) |
61 ms | 61 ms | -1.0% | 59 ms / 63 ms | 58 ms / 65 ms |
nuxt --help |
143 ms | 144 ms | +0.6% | 139 ms / 147 ms | 141 ms / 146 ms |
nuxt --help (first output byte) |
137 ms | 139 ms | +1.1% | 133 ms / 141 ms | 136 ms / 141 ms |
nuxt dev --help |
108 ms | 108 ms | -0.4% | 103 ms / 110 ms | 104 ms / 113 ms |
nuxt dev --help (first output byte) |
104 ms | 103 ms | -0.7% | 98 ms / 105 ms | 99 ms / 108 ms |
nuxt <unknown-command> (no-op) |
153 ms | 153 ms | -0.1% | 148 ms / 161 ms | 149 ms / 155 ms |
nuxt <unknown-command> (no-op) (first output byte) |
148 ms | 148 ms | -0.1% | 142 ms / 155 ms | 144 ms / 150 ms |
Module load cost
Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (built-ins excluded, native addons excluded).
| Command | baseline v4.0.0-alpha.1 modules | head v4.0.0-alpha.1 modules | Delta | baseline v4.0.0-alpha.1 source bytes | head v4.0.0-alpha.1 source bytes | Delta |
|---|---|---|---|---|---|---|
nuxt --version |
37 | 37 | 0.0% | 302.8 kB | 302.8 kB | 0.0% |
nuxt --help |
139 | 139 | 0.0% | 1.04 MB | 1.04 MB | 0.0% |
nuxt dev --help |
82 | 82 | 0.0% | 646.3 kB | 646.3 kB | 0.0% |
Install footprint and published tarball
Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.
| Metric | baseline v4.0.0-alpha.1 | head v4.0.0-alpha.1 | Delta |
|---|---|---|---|
Direct dependencies of @nuxt/cli |
22 | 22 | 0.0% |
| Packages in the installed tree (unique name@version) | 38 | 38 | 0.0% |
| Unique package names | 38 | 38 | 0.0% |
| Package directories on disk (cross-check) | 31 | 31 | 0.0% |
Installed node_modules on disk |
2.38 MB | 2.38 MB | +0.0% |
| Installed files | 407 | 407 | 0.0% |
| Install wall time (warm npm cache, median of 3) | 1.28 s | 1.34 s | +5.2% |
| Published tarball (packed) | 231.7 kB | 231.9 kB | +0.1% |
| Published tarball (unpacked) | 756.7 kB | 757.2 kB | +0.1% |
| Files in tarball | 84 | 84 | 0.0% |
Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (11)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request improves Nuxt CLI test reliability. Lifecycle cleanup retries temporary directory removal up to three times. Error-channel tests add Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. (9 skipped: 9 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1b06825 to
58c095b
Compare
886f542 to
5b5d110
Compare
🔗 Linked issue
📚 Description
small test fixture improvement