Skip to content

fix(dev): read a key that shares a chunk with a terminal reply - #1551

Merged
danielroe merged 1 commit into
mainfrom
fix/shared-chunk
Sep 21, 2026
Merged

danielroe merged 1 commit into
mainfrom
fix/shared-chunk

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 118a824b-afe9-4680-8ab5-d0341510f61d

📥 Commits

Reviewing files that changed from the base of the PR and between 9cb3b30 and 3a6ca9b.

📒 Files selected for processing (2)
  • packages/nuxt-cli/src/dev/tui/terminal-replies.ts
  • packages/nuxt-cli/test/unit/dev-keys.spec.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1551
    
    npm i https://pkg.pr.new/nuxi@1551
    
    npm i https://pkg.pr.new/@nuxt/cli@1551
    

commit: 3a6ca9b

@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark

@nuxt/cli v4.0.0-alpha.1 (baseline) vs v4.0.0-alpha.1 (this PR)

Metric baseline v4.0.0-alpha.1 head v4.0.0-alpha.1 Delta
nuxt --version wall time (median) 55 ms 53 ms -2.6%
nuxt --help wall time (median) 113 ms 113 ms -0.1%
nuxt dev --help wall time (median) 87 ms 87 ms +0.9%
nuxt --version modules loaded 37 37 0.0%
nuxt --help modules loaded 139 139 0.0%
nuxt dev --help modules loaded 82 82 0.0%
Installed node_modules 2.38 MB 2.38 MB +0.0%
Published tarball (packed) 231.7 kB 231.9 kB +0.1%
Full report

@nuxt/cli v4.0.0-alpha.1 (baseline) vs v4.0.0-alpha.1 (head)

Setting Value
Baseline ref:9cb3b3025b94b64acee0fd878c88a199deefc616 (v4.0.0-alpha.1)
Head local packages/nuxt-cli at 3f51550 (v4.0.0-alpha.1)
Node v24.21.0
OS Linux 6.17.0 (kernel 6.17.0-1022-azure)
CPU AMD EPYC 9V74 80-Core Processor x 4
Memory 15.6 GB
Load average at start 0.79, 0.23, 0.08
Run started 2026-09-21T23:03:31.727Z

Cold CLI startup

Median of 15 interleaved runs per command, one warmup discarded.

Command baseline v4.0.0-alpha.1 median head v4.0.0-alpha.1 median Delta baseline v4.0.0-alpha.1 min / p95 head v4.0.0-alpha.1 min / p95
nuxt --version 55 ms 53 ms -2.6% 51 ms / 57 ms 51 ms / 56 ms
nuxt --version (first output byte) 51 ms 49 ms -2.3% 47 ms / 53 ms 48 ms / 52 ms
nuxt --help 113 ms 113 ms -0.1% 110 ms / 115 ms 110 ms / 116 ms
nuxt --help (first output byte) 108 ms 109 ms +0.4% 105 ms / 111 ms 105 ms / 111 ms
nuxt dev --help 87 ms 87 ms +0.9% 83 ms / 90 ms 82 ms / 95 ms
nuxt dev --help (first output byte) 82 ms 83 ms +1.3% 78 ms / 86 ms 78 ms / 90 ms
nuxt <unknown-command> (no-op) 120 ms 120 ms +0.3% 117 ms / 127 ms 116 ms / 125 ms
nuxt <unknown-command> (no-op) (first output byte) 115 ms 115 ms +0.4% 112 ms / 122 ms 112 ms / 120 ms

Module load cost

Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (built-ins excluded, native addons excluded).

Command baseline v4.0.0-alpha.1 modules head v4.0.0-alpha.1 modules Delta baseline v4.0.0-alpha.1 source bytes head v4.0.0-alpha.1 source bytes Delta
nuxt --version 37 37 0.0% 302.8 kB 302.8 kB 0.0%
nuxt --help 139 139 0.0% 1.04 MB 1.04 MB 0.0%
nuxt dev --help 82 82 0.0% 646.3 kB 646.3 kB 0.0%

Install footprint and published tarball

Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.

Metric baseline v4.0.0-alpha.1 head v4.0.0-alpha.1 Delta
Direct dependencies of @nuxt/cli 22 22 0.0%
Packages in the installed tree (unique name@version) 38 38 0.0%
Unique package names 38 38 0.0%
Package directories on disk (cross-check) 31 31 0.0%
Installed node_modules on disk 2.38 MB 2.38 MB +0.0%
Installed files 407 407 0.0%
Install wall time (warm npm cache, median of 3) 1.01 s 1.01 s -0.4%
Published tarball (packed) 231.7 kB 231.9 kB +0.1%
Published tarball (unpacked) 756.7 kB 757.2 kB +0.1%
Files in tarball 84 84 0.0%

Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.

@danielroe
danielroe enabled auto-merge September 21, 2026 23:04
@codspeed

codspeed Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing fix/shared-chunk (3a6ca9b) with main (ef54a25)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (9cb3b30) during the generation of this report, so ef54a25 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@danielroe
danielroe added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 1ee2c42 Sep 21, 2026
24 checks passed
@danielroe
danielroe deleted the fix/shared-chunk branch September 21, 2026 23:16
@github-actions github-actions Bot mentioned this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant