test(usercentrics): use the repo cold-start budget for the loader tag wait by harlan-zw · Pull Request #958 · nuxt/scripts

harlan-zw · 2026-10-12T11:21:47Z

🔗 Linked issue

📚 Description

The v3 loader tag renders after Nuxt resolves suspense and the idle callback runs, and a cold fixture start on CI can push that well past domcontentloaded, so the fixed 15s wait flaked. This gives the wait the same 30s cold-start budget the ahrefs and linkedin suites already use, with a matching 90s test timeout.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

… wait

vercel · 2026-10-12T11:21:53Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
scripts-playground	Ready	Preview	Oct 12, 2026 11:43am UTC

harlan-zw · 2026-10-12T11:22:47Z

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-12 12:55 UTC.

GitHub merged this pull request.

The flake budget bump may be insufficient: short waits after the initial selector wait and unchanged suites can still exceed their timeouts on a cold CI start, and CI on head is red. View code Next: Raise the remaining 15000 waitForFunction budget in this suite (and audit calendly/linkedin/partytown suites) to a cold-start-safe value, then confirm the "test" check passes on head.
Logged (0/100): Minor comment wording suggests uniform 90s timeout across suites, which is only true for usercentrics; harmless documentation drift. View code Optional follow-up: Optionally reword the comment to state the 90s timeout applies to this suite only.
- Ask an agent to verify and fix this finding

The pull request closed.

Selected findings run after merge and open separate pull requests.

coderabbitai · 2026-10-12T11:23:00Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: bcf3b870-b79d-4578-8df1-eddfeda2fa86

📥 Commits

Reviewing files that changed from the base of the PR and between 068de45 and cf712e0.

📒 Files selected for processing (1)

test/e2e/_ahrefs-analytics-suite.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 4fb37866-68a6-4487-b462-df73acb32547

📥 Commits

Reviewing files that changed from the base of the PR and between 965839c and 068de45.

📒 Files selected for processing (1)

test/e2e/_usercentrics-suite.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The Usercentrics end-to-end suite adds a shared 30-second timeout for waiting for the loader script. The loader-rendering test timeout increases from 60 to 90 seconds.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 068de

The longer loader wait accommodates the stated cold-start delay, and the described waits fit within the 90-second test limit. No material merge risk remains.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: increasing the Usercentrics loader-tag wait to use the repository cold-start budget.
Description check		The description directly explains the CI flake, the timing behavior, and the matching 30-second wait and 90-second test timeout changes.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

🛠️ Fix failing CI checks 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-12T11:23:55Z

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts-devtools@958

npm i https://pkg.pr.new/@nuxt/scripts@958

commit: cf712e0

github-actions · 2026-10-12T11:27:35Z

📦 Package Size

✅ No notable size changes

📚 22 runtime dependencies (no change)

All tracked output (25)

Package output	Gzipped	Raw
@nuxt/scripts-cli · runtime dependencies	72 kB	355 kB	✅
@nuxt/scripts-cli · dependency magicast	72 kB	355 kB	✅
@nuxt/scripts-cli · export .	3.4 kB	12 kB	✅
@nuxt/scripts-cli · published payload	3.4 kB	12 kB	✅
@nuxt/scripts · runtime dependencies	543 kB	2.40 MB	✅
@nuxt/scripts · dependency @oxc-project/types	0 B	0 B	✅
@nuxt/scripts · dependency @vueuse/core	178 kB	720 kB	✅
@nuxt/scripts · dependency @vueuse/shared	39 kB	152 kB	✅
@nuxt/scripts · dependency lru-cache	141 kB	623 kB	✅
@nuxt/scripts · dependency semver	25 kB	72 kB	✅
@nuxt/scripts · dependency sirv	8.8 kB	21 kB	✅
@nuxt/scripts · dependency unstorage	70 kB	225 kB	✅
@nuxt/scripts · dependency valibot	82 kB	590 kB	✅
@nuxt/scripts · dist/runtime	104 kB	306 kB	✅
@nuxt/scripts · export .	26 kB	106 kB	✅
@nuxt/scripts · export ./registry	30 kB	94 kB	✅
@nuxt/scripts · export ./stats	13 kB	92 kB	✅
@nuxt/scripts · export ./types-source	49 kB	247 kB	✅
@nuxt/scripts · published payload	222 kB	845 kB	✅
@nuxt/scripts · app runtime	176 B	658 B	✅
@nuxt/scripts · components runtime	2.5 kB	6.4 kB	✅
@nuxt/scripts · composables runtime	7.8 kB	26 kB	✅
@nuxt/scripts · registry runtime	46 kB	136 kB	✅
@nuxt/scripts · server runtime	30 kB	89 kB	✅
@nuxt/scripts · utils runtime	2.9 kB	8.1 kB	✅

Runtime dependencies (22)

Package	Dependency	Requested	Resolved	Cost
@nuxt/scripts-cli	magicast	^0.5.5	0.5.5	📦 72 kB gzip
@nuxt/scripts-cli	pathe	^2.0.3	2.0.3	♻️ free via Nuxt 4.6.0
@nuxt/scripts	@nuxt/kit	^4.6.0	4.6.0	♻️ free via Nuxt 4.6.0
@nuxt/scripts	@oxc-project/types	^0.153.0	0.153.0	📦 0 B gzip
@nuxt/scripts	@vueuse/core	^15.0.0	15.0.0	📦 178 kB gzip
@nuxt/scripts	@vueuse/shared	^15.0.0	15.0.0	📦 39 kB gzip
@nuxt/scripts	consola	^3.4.2	3.4.2	♻️ free via Nuxt 4.6.0
@nuxt/scripts	defu	^6.1.7	6.1.7	♻️ free via Nuxt 4.6.0
@nuxt/scripts	lru-cache	^11.5.3	11.5.3	📦 141 kB gzip
@nuxt/scripts	magic-string	^1.4.3	1.4.3	♻️ free via Nuxt 4.6.0
@nuxt/scripts	ofetch	^1.5.1	1.5.1	♻️ free via Nuxt 4.6.0
@nuxt/scripts	ohash	^2.0.12	2.0.12	♻️ free via Nuxt 4.6.0
@nuxt/scripts	oxc-walker	^1.1.1	1.1.1	♻️ free via Nuxt 4.6.0
@nuxt/scripts	pathe	^2.0.3	2.0.3	♻️ free via Nuxt 4.6.0
@nuxt/scripts	semver	^7.8.5	7.8.5	📦 25 kB gzip
@nuxt/scripts	sirv	^3.0.2	3.0.2	📦 8.8 kB gzip
@nuxt/scripts	std-env	^4.3.0	4.3.0	♻️ free via Nuxt 4.6.0
@nuxt/scripts	ufo	^1.6.4	1.6.4	♻️ free via Nuxt 4.6.0
@nuxt/scripts	ultrahtml	^1.7.0	1.7.0	♻️ free via Nuxt 4.6.0
@nuxt/scripts	unplugin	^3.4.0	3.4.0	♻️ free via Nuxt 4.6.0
@nuxt/scripts	unstorage	^1.17.5	1.17.5	📦 70 kB gzip
@nuxt/scripts	valibot	^1.5.0	1.5.0	📦 82 kB gzip

_{Baseline: main_@_965839c7___2026-10-12 · gzip is the comparison metric · changes below 16 B gzip are ignored}

harlan-zw · 2026-10-12T11:56:46Z

Open (82/100): The flake budget bump may be insufficient: short waits after the initial selector wait and unchanged suites can still exceed their timeouts on a cold CI start, and CI on head is red.

Proof: The required check "test" fails on the head commit cf712e0 while the PR's purpose is to stop that flake. Line 82 still bounds a later waitForFunction at 15000, and other suites (calendly, linkedin, partytown) keep 15000 waits under 60000 te.

Next: Raise the remaining 15000 waitForFunction budget in this suite (and audit calendly/linkedin/partytown suites) to a cold-start-safe value, then confirm the "test" check passes on head.

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy.

test(usercentrics): use the repo cold-start budget for the loader tag…

068de45

… wait

vercel Bot deployed to Preview October 12, 2026 11:23 View deployment

test(ahrefs): use the repo cold-start budget for the loader tag wait

cf712e0

harlan-zw removed the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 12, 2026

vercel Bot deployed to Preview October 12, 2026 11:43 View deployment

harlan-zw commented Oct 12, 2026

View reviewed changes

harlan-zw added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-blocked The automated Review found a material defect in this head commit. labels Oct 12, 2026

harlan-zw merged commit 8d873aa into main Oct 12, 2026
16 checks passed

harlan-zw deleted the fix/baseline-ci-965839c72cf8 branch October 12, 2026 12:14

harlan-zw removed the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 12, 2026

Navigation Menu

Repository navigation

test(usercentrics): use the repo cold-start budget for the loader tag wait - #958

test(usercentrics): use the repo cold-start budget for the loader tag wait#958
harlan-zw merged 2 commits into
mainfrom
fix/baseline-ci-965839c72cf8

harlan-zw commented Oct 12, 2026

Uh oh!

vercel Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

harlan-zw commented Oct 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

Review limit reached

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 12, 2026

Uh oh!

harlan-zw Oct 12, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

harlan-zw commented Oct 12, 2026

🔗 Linked issue

📚 Description

Uh oh!

vercel Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harlan-zw commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 MERGED

Uh oh!

coderabbitai Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026

📦 Package Size

Uh oh!

harlan-zw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Oct 12, 2026 •

edited

Loading

harlan-zw commented Oct 12, 2026 •

edited

Loading

coderabbitai Bot commented Oct 12, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 12, 2026 •

edited

Loading