Skip to content

fix(ci): skip stale workflow results and quote headers - #960

Merged
harlan-zw merged 3 commits into
mainfrom
fix/release-channel-ci
Oct 12, 2026
Merged

harlan-zw merged 3 commits into
mainfrom
fix/release-channel-ci

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Follow-up to #956.

📚 Description

The release workflow can receive CI results from commits made before release automation existed. Those checkouts lack the planning script, so release preparation fails.

Skip those historical CI results. Use consistent quoting for registry request headers to satisfy the lint rule.

The package size report can also finish after its PR closes or moves to another commit. Skip comments for those stale results.

Skip stale workflow results

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Approve automated work for the current issue state or pull request head commit. label Oct 12, 2026
@vercel

vercel Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
scripts-playground Ready Ready Preview Oct 12, 2026 12:46pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 11b8699b-b85f-48cc-af23-acc49f46802c

📥 Commits

Reviewing files that changed from the base of the PR and between 34e68ac and a1a7e89.


📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • scripts/check-release-channel.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.



📝 Walkthrough
📝 Walkthrough

Walkthrough

The release-planning step skips the planner for workflow_run events when the checked-out commit lacks scripts/prepare-release.ts, and sets the release output to false. Other events continue to run the planner. The registry request now quotes the accept header key; its value and other request options are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes


Merge Risk: ⚪ Minimal · up to a1a7e

The historical-run guard skips planning when the checked-out commit lacks the planner, without triggering release actions. The header edit does not change registry requests; no actionable merge risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly summarizes both main changes: skipping stale release workflow results and quoting registry headers.
Description check Passed The description directly explains the stale workflow result problem and the registry header quoting change.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts-devtools@960
npm i https://pkg.pr.new/@nuxt/scripts@960

commit: a1a7e89

@harlan-zw harlan-zw changed the title fix(ci): skip historical runs and quote registry headers fix(ci): skip stale workflow results and quote headers Oct 12, 2026
@harlan-zw
harlan-zw merged commit f8ebc7c into main Oct 12, 2026
14 of 15 checks passed
@harlan-zw
harlan-zw deleted the fix/release-channel-ci branch October 12, 2026 12:47

This branch was successfully deployed

1 active deployment
Preview — 478c4b2a Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harlan-agent-review Approve automated work for the current issue state or pull request head commit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant