Repository navigation
Conversation
uuid.UUID is a [16]byte array, so it never reached the TextUnmarshaler check that oapi-codegen#45 added to the struct branch and still failed with "unhandled type: uuid.UUID". Handle array kinds that implement encoding.TextUnmarshaler, as BindStringToObject already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45 (for #44) added a
TextUnmarshalercheck to the struct branch ofassignPathValuesso that types likeuuid.UUIDbind. Butuuid.UUIDis[16]byte, an array kind, so it never reaches that branch, and a deepObject parameter with aformat: uuidfield still fails:This adds a
reflect.Arraycase that usesUnmarshalTextwhen the type implements it, asBindStringToObjectalready does (bindstring.go). Other arrays still returnunhandled type.TestDeepObject_UUIDFieldscoversuuid.UUIDand*uuid.UUIDfields, an invalid UUID, and a plain[2]string. The first two rows fail on main.go test ./...,go vetand golangci-lint (2.13.2 locally, CI uses 2.15.0) pass.Written with AI assistance (Claude); I have reviewed the change.