Repository navigation
fix(ci): patch rustls, share one Postgres - #476
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things were keeping
mainred or about to go red.1.
Postgres integration testshung onmain(run 38570274487). The job started a freshpostgres:17container per test, so nextest's first four tests all pulled the image at the same moment. That takes 11-19s when the registry answers; in that run all four sat past the 120s hang cutoff with nothing passing. A re-run of the failed job went green, so nothing in the code was wrong. The commit that went red (#463) only toucheddependabot.yml.test-integrationalready avoids this by pointing the tests at one shared server (ODAL_TEST_PG_ADMIN_URL) and cloning a database from a migrated template.test-postgrespredates that and never got it. This gives it the samepostgres:17service container and env var. The runner pulls a service image once, before any step starts, and the tests have nothing left to pull. Every test inpg_integrationgoes throughstart_pg(), so none needs a container of its own. The job and its name are unchanged, since the name is what the ruleset's required check refers to.2.
Security auditfails onrustls 0.23.45. Four advisories published today (RUSTSEC-2026-0346, -0347, -0348, -0349) are all fixed in 0.23.46. The same advisories are whySecurity auditis red on the open Dependabot branches.rustlsis only a transitive dependency (reqwest, sqlx, bollard), so this is a lockfile-only bump of that one package, version and checksum, with no other entry touched. Without it this PR's own audit job would fail.just checkpasses locally.