Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new markdown documentation page for the Metabase query "Internal Supply Delivery Purchase Summary by Location", describing its purpose, parameters, SQL, and notes.
Changes:
- New documentation file describing the query, parameters (
created_date,location), and supplier hardcoding caveat. - Includes the full SQL with Metabase optional filter clauses and explanatory notes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jacobjeevan
requested changes
May 19, 2026
Jacobjeevan
reviewed
May 22, 2026
Comment out filters for created_date and location in query.
Jacobjeevan
reviewed
May 25, 2026
| JOIN emr_product p ON ii.product_id = p.id | ||
| JOIN emr_productknowledge pk ON p.product_knowledge_id = pk.id | ||
| WHERE delivery_order.supplier_id = 20697 | ||
| AND sd.deleted = FALSE |
Collaborator
There was a problem hiding this comment.
This check isn't needed; we generally don't use deleted flag if status is available (do check w/ previous queries whether we have any data like that).
Removed conditions for deleted records in the query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://data-public.ssmmhospital.com/question/250-internal-supply-delivery-purchase-summary-by-location?created_date=&location=