client: report connection failures consistently when streaming - #741
Open
LaoChouPro wants to merge 1 commit into
Open
LaoChouPro wants to merge 1 commit into
LaoChouPro wants to merge 1 commit into
Conversation
Translate httpx connection errors in both streaming request paths using the same message as ordinary requests. Keep server response errors intact. Assisted-by: OpenAI GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Ollama is unreachable, streaming requests currently expose a raw httpx error instead of the helpful ConnectionError used by ordinary requests. Apply the same handling to synchronous and asynchronous streams while preserving server response errors. This addresses the remaining streaming case from issue 120.
Tests cover all five streaming methods, non-streaming parity, HTTP errors and errors inside successful streams. All 126 tests and doctests pass, along with Ruff checks, formatting and package builds.