Update golanci-lint version and fix linting issues - #178
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository’s linting toolchain to a newer golangci-lint release and adjusts code/config to satisfy updated lint rules, keeping local (pre-commit) and CI linting aligned.
Changes:
- Bump
golangci-linttov2.12.2in both pre-commit and CI workflow configuration. - Update
.golangci.ymllinter enablement to match the newergolangci-lintsetup (includinggomodguard_v2and additional linters). - Fix Go test lint findings by deduplicating repeated string literals via test constants.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
nrfcache/nrfcache_test.go |
Replaces repeated literals with shared test constants to address linting (e.g., goconst) findings. |
.pre-commit-config.yaml |
Updates golangci-lint rev and ensures YAML formatting hook is present/ordered. |
.golangci.yml |
Aligns enabled linters/settings with the updated golangci-lint configuration and rules. |
.github/workflows/main.yml |
Bumps CI lint workflow input to use golangci-lint v2.12.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cmaciocco
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.