Skip to content

update readFromStream example - #1572

Open
juniortaeza wants to merge 8 commits into
open-source-parsers:masterfrom
juniortaeza:example-branch
Open

juniortaeza wants to merge 8 commits into
open-source-parsers:masterfrom
juniortaeza:example-branch

Conversation

@juniortaeza

Copy link
Copy Markdown

readFromString provides an example accessing data by index key e.g., root["Name"].asString(), but readFromStream's example isn't as comprehensive.

I've updated the readFromStream example to not only collect and print comments, but capture an array of json objects through the use of the Json::ValueIterator class. More documentation provided here.

@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Expands the stream-reading example to show reading fields from an array.

  • The stream example prints each record’s nested ID and value.

Reviews (6) · Last reviewed commit: "Merge branch 'master' into example-branc..." · Reviewed by Greptile

Comment thread example/readFromStream/readFromStream.cpp Outdated
Comment thread example/readFromStream/readFromStream.cpp Outdated
@juniortaeza

Copy link
Copy Markdown
Author

It's been a while, but I've addressed any outstanding issues and I believe this would be a good contribution and extended look into how the parser can be used.

@baylesj could you approve the workflows?

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 40052583645

Coverage remained the same at 89.907%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2740
Covered Lines: 2615
Line Coverage: 95.44%
Relevant Branches: 2640
Covered Branches: 2222
Branch Coverage: 84.17%
Branches in Coverage %: Yes
Coverage Strength: 23828.01 hits per line

💛 - Coveralls

Comment thread example/readFromStream/readFromStream.cpp Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@juniortaeza

Copy link
Copy Markdown
Author

@coveralls Check again please

@juniortaeza

Copy link
Copy Markdown
Author

@baylesj Hi there, could you approve the workflows please so I could see if anything else needs further fixing? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants