Skip to content

ci: test secure-memory builds in the CMake matrix - #1714

Open
Alb3e3 wants to merge 2 commits into
open-source-parsers:masterfrom
Alb3e3:ci/test-secure-memory
Open

Alb3e3 wants to merge 2 commits into
open-source-parsers:masterfrom
Alb3e3:ci/test-secure-memory

Conversation

@Alb3e3

@Alb3e3 Alb3e3 commented Sep 7, 2026

Copy link
Copy Markdown

Fixes #1712.

Add secure-memory ON/OFF builds to the existing CMake matrix across Ubuntu,
Windows, macOS and C++11/17/20. Use Debug consistently across generators and run
CTest after building, including the reader/writer suites as well as unit tests.

Verified locally with GCC 15.2: all three CTest suites pass in each of the six
secure-memory/C++ configurations. The pre-#1709 secure build fails on string
allocator mismatches. Restoring only the old CZString cleanup call on current
master also makes the secure CTest run fail at ValueTest/CZStringCoverage.
Actionlint passes. Windows and macOS still need the GitHub runners.

Prepared with AI assistance; the validation commands above were run locally.

@greptile-apps

greptile-apps Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no blocking issue was found.

Summary

Adds secure-memory ON/OFF coverage to the CMake matrix.

  • CMake CI builds both secure-memory modes and runs tests in Debug.

Reviews (2) · Last reviewed commit: "Merge branch 'master' into ci/test-secur..." · Reviewed by Greptile

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 40347649821

Coverage remained the same at 89.926%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2740
Covered Lines: 2615
Line Coverage: 95.44%
Relevant Branches: 2640
Covered Branches: 2223
Branch Coverage: 84.2%
Branches in Coverage %: Yes
Coverage Strength: 23835.16 hits per line

💛 - Coveralls

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Action should be added to ensure JSONCPP_USE_SECURE_MEMORY build does not regress

3 participants