[BUILD] add missing link dependency for bazel#4220
Merged
Conversation
This adds the `//sdk/src/metrics` link dependency for two libraries that need to use `AdaptingCircularBufferCounter` for `Base2ExponentialHistogramPointData`. Resolves open-telemetry#4219.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 415 415
Lines 17431 17431
=======================================
Hits 14435 14435
Misses 2996 2996 🚀 New features to boost your workflow:
|
ThomsonTan
approved these changes
Jul 7, 2026
Contributor
|
@grrtrr please fix the format. |
marcalff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
//sdk/src/metricslink dependency for two libraries that need to useAdaptingCircularBufferCounterforBase2ExponentialHistogramPointData.Fixes #4219.
Changes
Added the missing dependencies. Verified in our builds that the
otlp_recordableno longer brings unresolved symbols into the build.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes