[CODE HEALTH] Move ext and exporters test classes into anonymous namespace#4225
Open
mateenali66 wants to merge 1 commit into
Open
Conversation
…space Give the test fixtures and helpers in ext/test/http/url_parser_test, exporters/ostream/test/ostream_span_test and exporters/memory/test/in_memory_metric_exporter_test internal linkage by moving them into an anonymous namespace, clearing the remaining misc-use-internal-linkage warnings in those files. Lower the clang-tidy warning_limit accordingly. Part of open-telemetry#4196. Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
mateenali66
force-pushed
the
code-health/4196-ext-exporters-anon-namespace
branch
from
d3ee236 to
3838f86
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4225 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 415 415
Lines 17452 17452
=======================================
Hits 14449 14449
Misses 3003 3003 🚀 New features to boost your workflow:
|
marcalff
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the misc-use-internal-linkage cleanup from #4196, picking up the ext and exporters test files thc1006 left open in #4217.
Moves the test fixtures and helpers into anonymous namespaces so they get internal linkage:
Test-only, no behavior change. Lowered the clang-tidy warning_limit by 5 for both ABI presets.
Part of #4196.