Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -235,4 +235,45 @@ void create_SpiExporter_Valid() {
assertThat(((SamplerComponentProvider.TestSampler) sampler).config.getString("key1"))
.isEqualTo("value1");
}

@Test
void create_JaegerRemote_interval() {
Sampler sampler =
SamplerFactory.getInstance()
.create(
new SamplerModel()
.withJaegerRemoteDevelopment(
new ExperimentalJaegerRemoteSamplerModel()
.withEndpoint("http://jaeger-remote-endpoint")
.withInterval(10_000)
.withInitialSampler(
new SamplerModel().withAlwaysOff(new AlwaysOffSamplerModel()))),
context);
cleanup.addCloseable(sampler);

assertThat(sampler)
.isInstanceOf(JaegerRemoteSampler.class)
.extracting("pollingIntervalMs")
.isEqualTo(10_000);
}

@Test
void create_JaegerRemote_intervalDefault() {
Sampler sampler =
SamplerFactory.getInstance()
.create(
new SamplerModel()
.withJaegerRemoteDevelopment(
new ExperimentalJaegerRemoteSamplerModel()
.withEndpoint("http://jaeger-remote-endpoint")
.withInitialSampler(
new SamplerModel().withAlwaysOff(new AlwaysOffSamplerModel()))),
context);
cleanup.addCloseable(sampler);

assertThat(sampler)
.isInstanceOf(JaegerRemoteSampler.class)
.extracting("pollingIntervalMs")
.isEqualTo(60_000);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
private static final String TYPE = "remoteSampling";

private final String serviceName;
private final int pollingIntervalMs;
private final ScheduledExecutorService pollExecutor;
private final ScheduledFuture<?> pollFuture;

Expand All @@ -47,7 +48,7 @@

private final GrpcSender grpcSender;
private final URI endpoint;
private final int pollingIntervalMs;

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 25)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 17)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 11)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 8)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 26)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 11)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 8)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 25)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 26)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 21)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 17)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / analyze (java)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

Check failure on line 51 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 21)

variable pollingIntervalMs is already defined in class JaegerRemoteSampler

JaegerRemoteSampler(
GrpcSender grpcSender,
Expand All @@ -56,15 +57,16 @@
int pollingIntervalMs,
Sampler initialSampler) {
this.serviceName = serviceName != null ? serviceName : "";
this.pollingIntervalMs = pollingIntervalMs;
this.grpcSender = grpcSender;
this.endpoint = endpoint;
this.pollingIntervalMs = pollingIntervalMs;

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 25)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 17)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 11)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 8)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 26)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 11)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 8)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 25)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 26)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 21)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 17)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / analyze (java)

variable pollingIntervalMs might already have been assigned

Check failure on line 63 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 21)

variable pollingIntervalMs might already have been assigned
this.sampler = initialSampler;
pollExecutor = Executors.newScheduledThreadPool(1, new DaemonThreadFactory(WORKER_THREAD_NAME));
pollFuture =
pollExecutor.scheduleWithFixedDelay(
this::getAndUpdateSampler, 0, pollingIntervalMs, TimeUnit.MILLISECONDS);
}

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 25)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 17)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 11)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 8)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 26)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 11)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 8)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 25)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 26)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 21)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (ubuntu-latest, 17)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / analyze (java)

variable pollingIntervalMs might not have been initialized

Check failure on line 69 in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java

View workflow job for this annotation

GitHub Actions / Build (macos-latest, 21)

variable pollingIntervalMs might not have been initialized

@Override
public SamplingResult shouldSample(
Expand Down Expand Up @@ -186,6 +188,11 @@
return this.sampler;
}

// Visible for testing
int getPollingIntervalMs() {
return this.pollingIntervalMs;
}

public static JaegerRemoteSamplerBuilder builder() {
return new JaegerRemoteSamplerBuilder();
}
Expand Down
Loading