Skip to content

Fix spelling typos in API and metrics test code #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Draft

Fix spelling typos in API and metrics test code #8689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...nternal/src/main/java/io/opentelemetry/api/testing/internal/AbstractDefaultMeterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ void noopMeterProvider_getDoesNotThrow() {
void noopMeterProvider_builderDoesNotThrow() {
MeterProvider provider = getMeterProvider();
provider.meterBuilder("user-instrumentation").build();
provider.meterBuilder("advanced-instrumetnation").setInstrumentationVersion("1.0").build();
provider.meterBuilder("advanced-instrumentation").setInstrumentationVersion("1.0").build();
provider.meterBuilder("schema-instrumentation").setSchemaUrl("myschema://url").build();
provider
.meterBuilder("schema-instrumentation")
Expand Down Expand Up @@ -181,7 +181,7 @@ void noopDoubleHistogram_doesNotThrow() {
}

@Test
void noopLongGauage_doesNotThrow() {
void noopLongGauge_doesNotThrow() {
LongGauge gauge =
meter
.gaugeBuilder("temperature")
Expand All @@ -205,7 +205,7 @@ void noopLongGauage_doesNotThrow() {
}

@Test
void noopObservableLongGauage_doesNotThrow() {
void noopObservableLongGauge_doesNotThrow() {
meter
.gaugeBuilder("temperature")
.ofLongs()
Expand All @@ -219,7 +219,7 @@ void noopObservableLongGauage_doesNotThrow() {
}

@Test
void noopDoubleGauage_doesNotThrow() {
void noopDoubleGauge_doesNotThrow() {
DoubleGauge gauge =
meter
.gaugeBuilder("temperature")
Expand All @@ -241,7 +241,7 @@ void noopDoubleGauage_doesNotThrow() {
}

@Test
void noopObservableDoubleGauage_doesNotThrow() {
void noopObservableDoubleGauge_doesNotThrow() {
meter
.gaugeBuilder("temperature")
.setDescription("The current temperature")
Expand Down
2 changes: 1 addition & 1 deletion ...ternal/src/main/java/io/opentelemetry/api/testing/internal/AbstractOpenTelemetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void getThenSet() {
assertThat(GlobalOpenTelemetry.isSet()).isFalse();
assertThat(GlobalOpenTelemetry.getOrNoop()).isSameAs(OpenTelemetry.noop());

// Calling GlobalOpenTelemetry.get() has the side affect of setting GlobalOpenTelemetry to an
// Calling GlobalOpenTelemetry.get() has the side effect of setting GlobalOpenTelemetry to an
// (obfuscated) noop.
// Call GlobalOpenTelemetry.get() using a utility method so we can later assert it was
// responsible for setting GlobalOpenTelemetry.
Expand Down
2 changes: 1 addition & 1 deletion sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/SdkMeterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ void builder_InvalidName() {
assertThat(sdkMeter.histogramBuilder("1").ofLongs().build())
.isSameAs(NOOP_METER.histogramBuilder(NOOP_INSTRUMENT_NAME).ofLongs().build());

// Gauage
// Gauge
assertThat(sdkMeter.gaugeBuilder("1").buildWithCallback(unused -> {}))
.isSameAs(NOOP_METER.gaugeBuilder(NOOP_INSTRUMENT_NAME).buildWithCallback(unused -> {}));
assertThat(sdkMeter.gaugeBuilder("1").ofLongs().buildWithCallback(unused -> {}))
Expand Down
Loading