feat: Update kafka python instrumentation to support kafka-python>=3#4786
Open
rjduffner wants to merge 3 commits into
Open
feat: Update kafka python instrumentation to support kafka-python>=3#4786rjduffner wants to merge 3 commits into
rjduffner wants to merge 3 commits into
Conversation
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While kafka-python version 3.0.0 is actually a pretty large change, https://github.com/dpkp/kafka-python/releases/tag/3.0.0, the breaking changes don't seem to be exercised by the instrumentation.
I updated the instrumentation to include support for versions > 3 but also kept testing older versions as well.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Make sure the current tests pass with the new library versions.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.