Skip to content

Strip only the leading uberctx- prefix from a Jaeger baggage key #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-bzhezytskyy wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

Strip only the leading uberctx- prefix from a Jaeger baggage key #5557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2304079
Strip only the leading uberctx- prefix from a baggage key
serhiy-bzhezytskyy Aug 19, 2026
000751f
Add changelog fragment for #5557
serhiy-bzhezytskyy Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5557.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-propagator-jaeger`: strip only the leading `uberctx-` prefix when extracting a baggage key, so a carrier key that repeats the prefix keeps its inner literal (`uberctx-a-uberctx-b` now yields `a-uberctx-b` rather than `a-b`).
2 changes: 1 addition & 1 deletion propagator/opentelemetry-propagator-jaeger/src/opentelemetry/propagators/jaeger/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def _extract_baggage(
if value is None:
continue
context = baggage.set_baggage(
key.replace(self.BAGGAGE_PREFIX, ""),
key[len(self.BAGGAGE_PREFIX) :],
urllib.parse.unquote(value).strip(),
context=context,
)
Expand Down
10 changes: 10 additions & 0 deletions propagator/opentelemetry-propagator-jaeger/tests/test_jaeger_propagator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ def get_context_new_carrier(old_carrier, carrier_baggage=None):


class TestJaegerPropagator(TestCase):
# pylint: disable=too-many-public-methods

@classmethod
def setUpClass(cls):
generator = id_generator.RandomIdGenerator()
Expand Down Expand Up @@ -134,6 +136,14 @@ def test_extract_empty_baggage_value(self):
context = FORMAT.extract(old_carrier)
self.assertDictEqual({"key3": "value3"}, context[_BAGGAGE_KEY])

def test_extract_strips_only_the_leading_baggage_prefix(self):
old_carrier = {
FORMAT.TRACE_ID_KEY: self.serialized_uber_trace_id,
"uberctx-a-uberctx-b": "value",
}
context = FORMAT.extract(old_carrier)
self.assertDictEqual({"a-uberctx-b": "value"}, context[_BAGGAGE_KEY])

def test_extract_invalid_uber_trace_id(self):
old_carrier = {
"uber-trace-id": "000000000000000000000000deadbeef:00000000deadbef0:00",
Expand Down