Skip to content

Guard sdk-java from NoSuchElementException #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Aug 11, 2026
+17 −1
Merged

Guard sdk-java from NoSuchElementException #1594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/BaseWorkflowBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,11 @@ private SELF appendDo(Consumer<DBuilder> configurer) {
configurer.accept(doBuilder);

final List<TaskItem> newItems = doBuilder.build().getDo();
if (newItems == null || newItems.isEmpty()) return self();
if (newItems == null || newItems.isEmpty()) {
throw new IllegalStateException(
"Task list must contain at least one task. "
+ "Use .tasks(d -> d.set(...)) or similar to define tasks.");
}
Comment on lines +139 to +143

final List<TaskItem> merged =
new ArrayList<>(this.workflow.getDo() != null ? this.workflow.getDo() : List.of());
Expand Down
12 changes: 12 additions & 0 deletions fluent/spec/src/test/java/io/serverlessworkflow/fluent/spec/WorkflowBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertInstanceOf;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import io.serverlessworkflow.api.types.AuthenticationPolicyUnion;
Expand Down Expand Up @@ -112,6 +113,17 @@ void testUseAuthenticationsBasic() {
assertNotNull(union.getBasicAuthenticationPolicy(), "BasicAuthenticationPolicy should be set");
}

@Test
void testEmptyTasksThrows() {
assertThrows(IllegalStateException.class, () -> WorkflowBuilder.workflow().tasks().build());
}

@Test
void testEmptyTasksConsumerThrows() {
assertThrows(
IllegalStateException.class, () -> WorkflowBuilder.workflow().tasks(d -> {}).build());
}

@Test
void testDoTaskSetAndForEach() {
Workflow wf =
Expand Down
Loading