fix(sdk): preserve canceled scan state - #735
Open
Hughhhhcoder wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44. When a caller cancels a registered SDK scan, the scan history is
currently finalized with
fail-scan, so an intentional cancellation is storedas a failure instead of a cancellation.
Changes
ScanInterruptedErrorvalues throughcancel-scan.fail-scanfor ordinary failures, internal tracking failures, andScanCostLimitExceededErrorso those errors retain their message and costmetadata.
arguments for a canceled scan.
Testing
bun test --timeout 30000 tests-ts/api.test.ts— 139 passed, 2 skipped, 0 failed.bun test --timeout 30000 tests-ts/scan-recovery.test.ts— 40 passed, 0 failed.pnpm --ignore-workspace run lint— passed.pnpm --ignore-workspace --dir ../../plugins/codex-security/mcp-app run typecheck— passed.pnpm --ignore-workspace run generate:models:check— passed.pnpm --ignore-workspace run format— passed.git diff --check— passed.Risk and rollout
This changes only the persisted lifecycle command for explicit caller/client
cancellation. Ordinary failures and cost-limit recovery retain the existing
failure path and metadata. No public API or scan input contract changes.
Public disclosure review