Use AbsolutePathBuf in skill loading and codex_home#17407
Use AbsolutePathBuf in skill loading and codex_home#17407pakrym-oai wants to merge 11 commits intomainfrom
Conversation
pakrym-oai
changed the title
|
@codex review |
…loading-absolute-paths
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4584735e78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/codex.rs
Outdated
| let empty_cli_overrides: &[(String, toml::Value)] = &[]; | ||
| for cwd in cwds { | ||
| let cwd_abs = match AbsolutePathBuf::try_from(cwd.as_path()) { | ||
| let cwd_abs = match AbsolutePathBuf::from_absolute_path_checked(cwd.as_path()) { |
There was a problem hiding this comment.
Use cwd normalization that accepts relative paths. Op::ListSkills takes Vec<PathBuf>, but this now calls AbsolutePathBuf::from_absolute_path_checked, which rejects relative cwd values and returns an error entry instead of scanning skills. Before this change, relative paths were normalized (via try_from/from_absolute_path). This is a behavior regression for callers that pass relative cwd inputs.
Useful? React with 👍 / 👎.
1 participant
Helps with FS migration later