Skip to content

Remove the legacy core review execution path#31923

Open
jif-oai wants to merge 1 commit into
jif/review-as-skillfrom
jif/remove-legacy-review
Open

Remove the legacy core review execution path#31923
jif-oai wants to merge 1 commit into
jif/review-as-skillfrom
jif/remove-legacy-review

Conversation

@jif-oai

@jif-oai jif-oai commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

review/start now runs through the bundled review-agent skill, so the dedicated core review session, task, prompt resolver, and one-shot delegate path are dead code.

This is stacked on #31841 so the app-server cutover remains independently reviewable.

What changed

  • remove the core Op::Review, ReviewRequest, ReviewTask, review session orchestration, and one-shot delegate wrapper
  • remove old review prompt resolution, templates, and execution-specific tests
  • make app-server ReviewDelivery self-contained and have codex exec use the app-server ReviewTarget directly
  • keep legacy review-mode events, review result types, source and error variants, and review_model config parsing for old rollout and config compatibility
  • document entered and exited review-mode items as replay-only

Compatibility

The app-server v2 review/start wire API and the CLI and TUI review entry points are unchanged. Removing the public core Op::Review and ReviewRequest variants is source-breaking for direct codex-core integrations; serialized legacy review events remain readable.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7be7e4516c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-utils-template = { workspace = true }

[dev-dependencies]
codex-utils-absolute-path = { workspace = true }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Refresh the Bazel lock after dependency changes

This change edits codex-prompts dependencies and Cargo.lock, but it does not include the corresponding MODULE.bazel.lock update. Bazel is wired to //codex-rs:Cargo.toml and //codex-rs:Cargo.lock, and CI checks lockfile drift with --lockfile_mode=error, so the Bazel jobs will fail until just bazel-lock-update is run and the generated lockfile is committed.

AGENTS.md reference: AGENTS.md:L37-L39

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant