fix: preserve Field constraints on variadic tool parameters - #4739
Open
rioyu123 wants to merge 1 commit into
Open
fix: preserve Field constraints on variadic tool parameters#4739rioyu123 wants to merge 1 commit into
rioyu123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes lost Pydantic
Fieldconstraints on variadic tool parameters.For example,
*scores: Annotated[int, Field(ge=0)]currently produces an unconstrained item schema and allows negative values to reach the tool callable. The same issue affects values collected through**kwargs.The fix preserves the existing
Fieldconstraint metadata on each positional item or keyword value when building the Pydantic model. As a result, the generated JSON schema and runtime validation both enforce the declared constraints, and invalid values are rejected before the callable runs.This is intentionally narrower than #4609: it only covers the existing supported
Annotated[T, Field(...)]form for*argsand**kwargs. It does not add support for arbitrary outerAnnotatedmetadata.Ordinary parameters, defaults and aliases, argument reconstruction, description precedence, existing tuple handling, and strict-schema behavior for arbitrary-key
**kwargsremain unchanged.Test plan
*argsand**kwargsconstraints in both generated schemas and actual tool invocation.Related context
#4609
Checks
.agents/skills/code-change-verification/scripts/run.sh.