fix(voice): normalize PCM16 float output correctly - #4755
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
fix(voice): normalize PCM16 float output correctly#4755sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes PCM16-to-float32 normalization in
StreamedAudioResult.The existing conversion divided signed 16-bit samples by
32767.0, which maps the valid minimum PCM16 sample-32768to approximately-1.00003. Using32768.0keeps the complete PCM16 range within the normalized float interval:-32768maps to-1.0and32767maps to approximately0.99997. This also matches the existing PCM16 normalization used by the realtime CLI example when computing audio RMS.The int16 output path, float32 output shape, buffering, and streaming behavior are unchanged.
Test plan
[-1.0, 1.0]and preserves the expected(n, 1)shape.Issue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR