fix(docs): check freshness for all translations - #4766
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2cebb725b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address that feedback |
|
Note To use Codex here, create an environment for this repo. |
e502898 to
808bf17
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1 participant
Summary
This pull request fixes
--mode only-changesin the documentation translation script so freshness is checked across every configured translation instead of Japanese only.should_translate_based_on_translation()currently compares the English source timestamp withdocs/ja/...and uses that single result to decide whethertranslate_single_source_file()should skip the page for all configured languages. If Japanese is current while Korean or Chinese is missing or stale, the source is incorrectly treated as fully up to date.The freshness check now walks the configured
languagesmapping and requests translation when any target file is missing, has no Git timestamp, or is older than the English source. The filesystem check deliberately happens before Git history lookup becausegit logcan still return the deletion commit for a missing tracked file. The script skips only when every configured translation exists and is current. The CLI help text is updated to describe that behaviour. Generated translated pages are not changed by this PR.Test plan
ja,ko,zh).Closes #4763.
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR