fix(sandbox): detect directory modes correctly - #4768
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes POSIX file-type detection in
Permissions.from_mode().The current implementation uses
bool(mode & stat.S_IFDIR)to decide whether a native mode represents a directory. POSIX file types are mutually exclusive values underS_IFMT, not independent bit flags, so that expression also evaluates true for some non-directory types. In particular, sockets (S_IFSOCK) and block devices (S_IFBLK) share theS_IFDIRbit and are incorrectly surfaced withdirectory=True.The fix uses Python's standard
stat.S_ISDIR(mode)predicate. The existing owner/group/other permission-bit decoding is unchanged.Test plan
Permissions.from_mode(mode).directorymatchesstat.S_ISDIR(mode)for each file type.Issue number
Closes #4767
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR