Repository navigation
fix(deps): bump blaxel from 0.2.50 to 0.4.19 - #5440
dependabot[bot] wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14a7509704
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "mcp" | ||
| version = "2.3.0" | ||
| version = "1.30.0" |
There was a problem hiding this comment.
When CI or contributors install the all-extras environment from this lock, this downgrade makes MCP_V2 false and causes the entire tests/mcp/test_mcp_v2_http.py suite to skip. The separate integration profile only pins MCP 1.x versions, so this change removes the repository's MCP v2 coverage even though pyproject.toml still supports MCP 2 and ordinary users can resolve it; retain MCP 2.3 in the main environment or avoid the Blaxel update until its constraint can coexist with that coverage.
AGENTS.md reference: AGENTS.md:L19-L19
Useful? React with 👍 / 👎.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Blocking dependency conflict: Blaxel 0.4.19 explicitly requires mcp>=1.9.4,<2.0.0 (the upstream manifest explains that its server subclasses the MCP 1.x FastMCP API). Resolving blaxel==0.4.19 together with the current mcp==2.3.0 fails. This PR therefore downgrades the main all-extras lock to MCP 1.30.0, breaks the typed MCP 2 test fixtures, and removes MCP 2 HTTP coverage; CI currently has eight failing jobs.
Please keep this PR open until an upstream Blaxel version can coexist with MCP 2, or provide a separately reviewed environment/CI split that preserves MCP 1 and MCP 2 coverage without overriding upstream constraints. The upstream default branch currently retains the same <2 cap. This update is not ready to merge.
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 14a7509704159f1284e9c8351d5650275578ce8c. The existing MCP v2 coverage finding still applies. The lock selects MCP 1.30 instead of 2.3, so the regular all-extras environment skips all 16 tests in tests/mcp/test_mcp_v2_http.py. The explicit compatibility matrix tests MCP 1.x; the separate packaging lanes do not run this transport suite. MCP 2 remains supported by the published requirement. Preserve an explicit MCP 2 transport-test lane without the incompatible Blaxel extra, or defer this bump until the dependencies can coexist.
I am referencing the existing inline finding rather than duplicating it. Source-only review; no dependencies were installed and no candidate code was executed. Hosted typecheck and seven test jobs failed on this head; those are readiness evidence, not additional code findings. I did not independently verify upstream package contents or live Blaxel behavior.
Bumps [blaxel](https://github.com/blaxel-ai/sdk-python) from 0.2.50 to 0.4.19. - [Release notes](https://github.com/blaxel-ai/sdk-python/releases) - [Commits](blaxel-ai/sdk-python@v0.2.50...v0.4.19) --- updated-dependencies: - dependency-name: blaxel dependency-version: 0.4.19 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
14a7509 to
0818cbf
Compare
Bumps blaxel from 0.2.50 to 0.4.19.
Release notes
Sourced from blaxel's releases.
... (truncated)
Commits
edce017sandbox: termination_grace_period_seconds and standby_grace_period_seconds on...e9b63fdfeat: add PostHog event tracking for SDK installs (ENG-2277) (#141)09cf277Add workspace secrets (SecretInstance.set/list/delete) (#275)b503846feat(customdomains): regenerate client with spec.validationMethod and add opt...c921c88feat(image): choose the build region on build() (#281)4f86a75feat(image): name build sizes build_memory and build_volume (#280)bedbc75fix(image): only send build headers the upload URL was signed for (#279)0a61fd5feat(image): set build worker memory and volume on build() (#278)9b95667test: align lifecycle tests with the 5m minimum sandbox TTL (#277)d6433eechore: regenerate SDK clients from latest API definitions (#276)