Repository navigation
chore: enforce generated-file ownership - #1284
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d7e019251
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Castiron-Internal-PR: openai/openai-java-internal#377 Castiron-Source-SHA: e3cbc36f43a0f45a8d1dec31e8f4035cd02c4fe2 Castiron-Public-Base-SHA: 4311dba
jbeckwith-oai
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92ef9b4cde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Policy update in 998c66a, following the repository owner's explicit direction: generated-file ownership relies on AGENTS.md and ordinary code review for now. Removed the proposed checksum/mode checker and its CI invocation, and updated contributor/security guidance accordingly. There is no dedicated generated-file edit gate in this rollout. The retired budget requirements are absent from the live rulesets and the old reporting workflows are disabled; normal SDK tests, security checks, CODEOWNER review and generation provenance remain. Requests to add a replacement generated-edit enforcement path are superseded by this policy decision. Monitoring the new CI head. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 998c66a58fb4849586c875a91c9c1616c2b8fbf1 against 4311dba26c34f5d813105f94f2a76ba9073561dc, including the final removal of the proposed generated-file checker. No actionable findings after source review and an independent incremental pass.
The retired budget tooling and its consumers are removed together. The final guidance explicitly relies on contributor instructions and ordinary code review, with no dedicated generated-edit gate. Existing lint/test entry points are preserved.
Validation: current-head hosted CI has 10 successful and 0 skipped checks; still running: CI / tests / sdk, CI / API compatibility, OkTest; no candidate code, tests or generation ran locally. I did not independently verify the author-reported live ruleset changes.
Retire generated-file customization budgets and rely on
AGENTS.md, contributor guidance, and ordinary code review for ownership. Generated files must not carry handwritten edits: fix the inputs/compiler and regenerate; put custom behavior in separately owned handwritten extensions.This combines normal Castiron-regenerated cleanup with SDK-owned documentation. It removes the budget reporters, workflows, zero-only policy, and the proposed dedicated file checker. There is no dedicated generated-file edit gate for now. The compiler replaces generated output and deletes retired paths without three-way replay.
The retired budget status requirements are removed and their producers disabled across public/private SDKs. Normal SDK checks, CODEOWNER review, generation/promotion provenance, and release pins remain. Generated output and inventory changes should be reviewed together.
Validation: documentation and workflow diffs checked; the unchanged generated output still matches normal generation. Relevant formatting and focused entrypoint/layout tests pass. Two consecutive independent review rounds and current-head CI are tracked for this revision.