fix(realtime): preserve explicitly set default-valued fields - #3730
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
fix(realtime): preserve explicitly set default-valued fields#3730sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude_unset=True, so fields the caller did not set remain omittedNonevalues such asturn_detection=None, allowing a session setting to be cleared or resetbeta.realtimeevent sendsFixes #2199
Test plan
uv run ruff format src/openai/resources/realtime/realtime.py src/openai/resources/beta/realtime/realtime.py tests/lib/test_realtime_event_serialization.pyuv run ruff check --fix tests/lib/test_realtime_event_serialization.pyuv run ruff check src/openai/resources/realtime/realtime.py src/openai/resources/beta/realtime/realtime.py tests/lib/test_realtime_event_serialization.pyuv run pytest -o addopts= -q tests/lib/test_realtime_event_serialization.pygit diff --checkAll focused verification steps passed before the branch was reduced to its single final commit.