Skip to content

fix(streaming): restore function name on arguments done events - #3731

Open
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/function-call-done-name-2723
Open

fix(streaming): restore function name on arguments done events#3731
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/function-call-done-name-2723

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

  • restore a missing name on response.function_call_arguments.done events from the already accumulated function-call snapshot
  • preserve a non-empty function name supplied by the server
  • leave raw response schemas and request behaviour unchanged
  • add focused regression coverage for both fallback and preservation cases

Fixes #2723

Test plan

  • uv run ruff format src/openai/lib/streaming/responses/_responses.py tests/lib/responses/test_function_call_done_event.py
  • uv run ruff check --fix tests/lib/responses/test_function_call_done_event.py
  • uv run ruff check src/openai/lib/streaming/responses/_responses.py tests/lib/responses/test_function_call_done_event.py
  • uv run pytest -o addopts= -q tests/lib/responses/test_function_call_done_event.py
  • git diff --check

All focused verification steps passed before the branch was reduced to its single final commit.

@sylvesterkaczmarek
sylvesterkaczmarek requested a review from a team as a code owner August 25, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Responses API streaming response.function_call_arguments.done event missing function name

1 participant