Skip to content

ci: remove duplicate HTTPX2 test job - #4172

Merged
dpiet-oai merged 1 commit into
mainfrom
codex/project-fast-ci-01-python-httpx2-ci
Oct 27, 2026
Merged

dpiet-oai merged 1 commit into
mainfrom
codex/project-fast-ci-01-python-httpx2-ci

Conversation

@dpiet-oai

@dpiet-oai dpiet-oai commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Changes being requested

Remove the dedicated test (HTTPX2) job and explicitly set OPENAI_TEST_HTTP_CLIENT=httpx2 on the retained Python test matrix. Both jobs used Python 3.14 and ran the same two Pydantic suites; the matrix continues to run both suites with the HTTPX2 transport. Update the provenance test's expected installer-job set without changing its assertions.

The active main ruleset now requires test (Python 3.14) and no longer requires the removed job. The merge queue will validate the remaining required checks.

Additional context & links

At base 43045fcaf91aec08571e54c57706597cefd32d45, the duplicate job took 187 seconds and finished before Python 3.14; this saves runner time, not 187 seconds of gate latency. Both jobs restored the same cache and reported identical Pydantic v2/v1 suite outcomes and installed dependency versions.

Validation: all four local collections (default/explicit HTTPX2 × Pydantic v2/v1) had the same 20,125 node IDs; five transport/provenance checks passed under each Pydantic version; Ruff, Python-version policy, and git diff --check passed.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: d7ab5ee237f8d8a8fa51dd7177a47cfbd6c331e6.

Trusted main policy: d7ab5ee237f8d8a8fa51dd7177a47cfbd6c331e6.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared d7ab5ee237f8 → e4898416b0e4. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 40521642158 --repo openai/openai-python \
  --name castiron-custom-code-40521642158-1 --dir /tmp/castiron-custom-code-40521642158-1
git apply --stat /tmp/castiron-custom-code-40521642158-1/custom-code.patch
cat /tmp/castiron-custom-code-40521642158-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin d7ab5ee237f8d8a8fa51dd7177a47cfbd6c331e6 e4898416b0e45b23dacade6d12338febe479a77c
python3 scripts/castiron/custom_code_report.py report \
  --base d7ab5ee237f8d8a8fa51dd7177a47cfbd6c331e6 \
  --head e4898416b0e45b23dacade6d12338febe479a77c --target-branch main --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-e4898416b0e4
cat /tmp/castiron-custom-code-e4898416b0e4/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@marcuswood-oai marcuswood-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 No changes requested.

Hosted Python 3.10/3.14 tests passed, with HTTPX2 and both Pydantic suites retained. The active ruleset still requires test (HTTPX2); the documented administrator update and merge-queue validation remain necessary before merge.


Reviewed: 575e020 · Base: 43045fc · sdk-pr-review

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 575e020cedc94df0d114d413965fdcf823a3ffb5. No blocking findings. The main Python matrix retains explicit HTTPX2 coverage and both Pydantic suites, so the separate job is redundant. Before merging, a repository administrator still needs to remove the obsolete test (HTTPX2) required status and verify the remaining merge-queue checks.

Source-only review; I did not run candidate code or tests. Hosted checks: 12 skipped, 21 success.

@dpiet-oai
dpiet-oai marked this pull request as ready for review October 27, 2026 14:14
@dpiet-oai
dpiet-oai requested a review from a team as a code owner October 27, 2026 14:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T14:28:43.908825Z e489841 New commits
🔒 Security Review ✅ Completed 2026-10-27T14:29:47.122434Z e489841 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dpiet-oai
dpiet-oai force-pushed the codex/project-fast-ci-01-python-httpx2-ci branch from 575e020 to e489841 Compare October 27, 2026 14:27
@dpiet-oai
dpiet-oai added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 0f434e4 Oct 27, 2026
31 checks passed
@dpiet-oai
dpiet-oai deleted the codex/project-fast-ci-01-python-httpx2-ci branch October 27, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants