Repository navigation
feat(api): accept typed references in Realtime response inputs - #4189
markstuart-oai wants to merge 1 commit into
Conversation
Castiron-Internal-PR: openai/openai-python-internal#349 Castiron-Source-SHA: 56ac8cdf4222ed97dc1f24faaa29f3bde9ab3633 Castiron-Public-Base-SHA: a3f4302
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40442437522 --repo openai/openai-python \
--name castiron-custom-code-40442437522-1 --dir /tmp/castiron-custom-code-40442437522-1
git apply --stat /tmp/castiron-custom-code-40442437522-1/custom-code.patch
cat /tmp/castiron-custom-code-40442437522-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin a3f430241c4a2e3e25bf79cc7d0148e51795a292 39ce401fed964166a9ab5b0fb9505c5a2a5ec125
python3 scripts/castiron/custom_code_report.py report \
--base a3f430241c4a2e3e25bf79cc7d0148e51795a292 \
--head 39ce401fed964166a9ab5b0fb9505c5a2a5ec125 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-39ce401fed96
cat /tmp/castiron-custom-code-39ce401fed96/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39ce401fed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Draft: A follow-up is fixing a typing regression for existing code that reads or mutates response inputs. Updated compatibility checks are in progress; the validation below describes the previous revision.
Summary
Pass existing Realtime item IDs as typed response input, alone or mixed with messages.
Changes
Validation
173 query, upload, and Chat Completions parsing and streaming tests passed before and after the change. Strict model and type checks accept existing, reference-only, and mixed Realtime response inputs, and reject references in creation events and references without IDs. The generated-code budget check passed at zero custom lines.