Repository navigation
chore(api): record completed generated-code separation - #4190
Conversation
Castiron-Internal-PR: openai/openai-python-internal#355 Castiron-Source-SHA: ca143874a707d772e76d929e26d16eab5890baad Castiron-Public-Base-SHA: 3596d18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40461710446 --repo openai/openai-python \
--name castiron-custom-code-40461710446-1 --dir /tmp/castiron-custom-code-40461710446-1
git apply --stat /tmp/castiron-custom-code-40461710446-1/custom-code.patch
cat /tmp/castiron-custom-code-40461710446-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 3596d18f05b63081fd64c6da82b515293afb98c6 398dfbd515fb0608c6ae26c1418b19f356006f8f
python3 scripts/castiron/custom_code_report.py report \
--base 3596d18f05b63081fd64c6da82b515293afb98c6 \
--head 398dfbd515fb0608c6ae26c1418b19f356006f8f --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-398dfbd515fb
cat /tmp/castiron-custom-code-398dfbd515fb/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Approved. The diff is limited to generation metadata and two transition documents. The previous and new public generated checkpoints have identical Git trees. The strict zero-line policy and SDK source are unchanged.
The inventory's 41 former mixed files match the pinned baseline's hashes and line counts, totaling 40,356 physical lines. The recorded modes match the 2,028-entry generated manifest. Historical measurements remain intact and are clearly separated from the current status. No blocking findings.
Source-only review: I did not run candidate tests, builds or generation. The compiler tests and legacy/native qualification remain author-reported. Hosted CI and the required human review remain separate gates.
Reviewed head: 398dfbd515fb0608c6ae26c1418b19f356006f8f; base: 3596d18f05b63081fd64c6da82b515293afb98c6.
Summary
Records the completed separation of generated SDK files and handwritten code. SDK code, public interfaces, and runtime behavior are unchanged.
Changes
Validation