feat(api): correct function argument completion event fields (openapi-545) - #622
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#84 Castiron-Source-SHA: 931278fbe721d2a51987552f7bb1a31f0e3ab21c Castiron-Public-Base-SHA: 347e659
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33913999289 --repo openai/openai-ruby \
--name castiron-custom-code-33913999289-1 --dir /tmp/castiron-custom-code-33913999289-1
git apply --stat /tmp/castiron-custom-code-33913999289-1/custom-code.patch
cat /tmp/castiron-custom-code-33913999289-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 347e659404bd7a13de57604e325c4432c875ee60 0484d8f1a0fdf1a6999e0803fdf488fb1882c3db
python3 scripts/castiron/custom_code_report.py report \
--base 347e659404bd7a13de57604e325c4432c875ee60 \
--head 0484d8f1a0fdf1a6999e0803fdf488fb1882c3db --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-0484d8f1a0fd
cat /tmp/castiron-custom-code-0484d8f1a0fd/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
The generated Ruby surface is internally consistent: the runtime models, websocket/server-event wrappers, RBI signatures, and RBS signatures all drop name together. That matters because leaving the field in only the static or wrapper layer would still make a valid terminal arguments event unusable for some consumers. item_id remains sufficient to recover the corresponding function-call identity.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the exact head. The stable and beta Responses models, websocket unions, RBI, and RBS stay consistent with the corrected contract, while function-call item and Realtime names remain unchanged. CI is green.
Summary
Removes the name model attribute from response.function_call_arguments.done to match the API response.
Changes