Persist space memberships in share manager#2760
Merged
Merged
Conversation
This gets us rid of quite a bit of special casing for space permission. Also provides us with "real" permission IDs instead of those faked "u:<userid>" ones.
The `id` property of the `permissions` on a space root does not longer have that special `u:<userid>` format any. It now has the same format as the permission id on "normal" driveItems.
…ervice In order to be able to run migrations, the "sharing" service now needs the "service_account_id" and -"_secret" to be configured. This is a "breaking/backwards incompatible" change.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | -3 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
aduffeck
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the current state of the feature/guest-links branch into main.
It fundamentally changes how we persist space-memberships. We basically treat them exactly like shares now and persist them in the share manager. (This was introduced with: opencloud-eu/reva#593 and opencloud-eu/reva#604)
This PR also introduces as migration to import all existing space-memberships into the share-manager. (Introduced in: opencloud-eu/reva#617). The migration is automatically executed at the start of the
sharingservice. While the migration is running the cloud can be accessed normally, with the exception of write operations to the share manager (those are e.g. triggered when create, updating or deleting shares, or when creating a new space or updating, adding or deleting members for a space. The space manager provides a progress log for the migration at "INFO" level. Even more verbose information is available at the "DEBUG" level. The migration is idempotent (i.e. when it is interrupted the migration re-runs at the next startup).