feat: add Open Graph metadata for public previews - #3334
Open
tammi-23 wants to merge 1 commit into
Open
Conversation
Contributor
|
Oh wow, this works? I was always convinced this would only work with server side rendering |
kulmann
reviewed
Sep 9, 2026
|
|
||
| /** | ||
| * Injects Open Graph tags (https://ogp.me) describing the currently displayed page, most notably | ||
| * public links. Only consumers that execute JavaScript pick these up; preview-specific tags for |
Member
There was a problem hiding this comment.
did you do research if crawlers nowadays do execute JS? Otherwise this whole PR would be kind of pointless. 馃檲
Contributor
There was a problem hiding this comment.
I mean, it can probably be tested easily... just paste a link into whatsapp or any other app that renders previews
Would be good to at least find one that works with your approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #2875
and add Open Graph tags for previews